core: enable use of dedicated oss-fuzz folder #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful during development purposes where it's convenient being able to adjust the OSS-Fuzz projects' folders. Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
|
/gcbrun exp -n dk-test-z-1 -m vertex_ai_gemini-1-5 -b minor-for-ci |
|
experiment is looking good (just to check no regressions) |
DonggeLiu
approved these changes
Jul 8, 2024
DonggeLiu
reviewed
Jul 8, 2024
| _set_temp_oss_fuzz_repo() | ||
| else: | ||
| global OSS_FUZZ_DIR | ||
| OSS_FUZZ_DIR = oss_fuzz_dir |
There was a problem hiding this comment.
Sorry I forgot to mention this nit: Swap the if-else block for better readability
if oss_fuzz_dir:
global OSS_FUZZ_DIR
OSS_FUZZ_DIR = oss_fuzz_dir
else:
_set_temp_oss_fuzz_repo()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful during development purposes where it's convenient being
able to adjust the OSS-Fuzz projects' folders, e.g. to test hypotheses.