Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fuzz target binary and source file from FI APIs #664

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

DonggeLiu
Copy link
Collaborator

So that we can use the cached images from OSS-Fuzz's chronos.
TODO:
Update other sets (e.g., comparison).

@DonggeLiu DonggeLiu marked this pull request as draft October 3, 2024 06:06
@DonggeLiu
Copy link
Collaborator Author

/gcbrun exp -n dg -ag

@DonggeLiu
Copy link
Collaborator Author

@DonggeLiu DonggeLiu marked this pull request as ready for review October 4, 2024 00:52
@DonggeLiu
Copy link
Collaborator Author

Dynamically collecting fuzz target binary & source file info will need to re-struct introspectory.py to avoid circular-dependency.
I will leave it for next time.

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if we can just remove these hardcoded values completely from the yaml files by default?

i.e. always call FI dynamically to get these if they don't exist in the yaml? There may still be some edge cases where we do need to hardcode them for certain projects, and we can still prioritize these ones when they exist.

@DonggeLiu
Copy link
Collaborator Author

LGTM, but I wonder if we can just remove these hardcoded values completely from the yaml files by default?

i.e. always call FI dynamically to get these if they don't exist in the yaml? There may still be some edge cases where we do need to hardcode them for certain projects, and we can still prioritize these ones when they exist.

Yep, good idea. That will address this issue.
Would it be OK to leave that to another PR later?
I wanted to quickly merge this so that we can maybe use #661 in this week's weekly exp.

@DonggeLiu DonggeLiu merged commit 6bc5565 into main Oct 4, 2024
6 checks passed
@DonggeLiu DonggeLiu deleted the update-benchmarks-target-api branch October 4, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants