Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect binary names #722

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Fix incorrect binary names #722

merged 3 commits into from
Nov 22, 2024

Conversation

DonggeLiu
Copy link
Collaborator

... and a script to find mismatched binary names between benchmark sets.

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonggeLiu
Copy link
Collaborator Author

can we just migrate to using https://introspector.oss-fuzz.com/api/harness-source-and-executable by default?

Yep that can solve the problems with outdated benchmark yamls, e.g., sleuthkit.
Some projects may need a bit more work, e.g., hermes has no result. I presume some projects have incorrect binary names too.

During my next exp, I will collect the projects whose fuzz target binaries cannot be found after compiling the human-written fuzz target. This step should be simple to add, but can help us rule out false negatives and inform us which projects to fix.

@DonggeLiu
Copy link
Collaborator Author

Testing it a bit more, we may need to further confirm the correctness of API query result before making it default.
For example, proftpd's fuzz target source file is at /src/proftpd/tests/fuzzing/json_fuzzer.c, but API result is /src/fuzzer.c.

@DonggeLiu
Copy link
Collaborator Author

/gcbrun skip

@DonggeLiu DonggeLiu merged commit 48f8c85 into main Nov 22, 2024
5 checks passed
@DonggeLiu DonggeLiu deleted the fix-binary-1 branch November 22, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants