Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix granting permissions only if there is a commit #725

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

maoyixie
Copy link
Collaborator

It seems that permissions should be granted even without commit.

@maoyixie maoyixie added the bug Something isn't working label Nov 22, 2024
Copy link
Collaborator

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep nice catch, thanks!

@DonggeLiu
Copy link
Collaborator

/gcbrun skip

@DonggeLiu DonggeLiu merged commit cd048ba into google:main Nov 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants