Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooled Prototyper #731

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Tooled Prototyper #731

wants to merge 9 commits into from
+330 −164

Conversation

DonggeLiu
Copy link
Collaborator

Utilize Gemini's Tool API in prototyper.

@DonggeLiu
Copy link
Collaborator Author

DonggeLiu commented Nov 27, 2024 •
edited
Loading

They are two main blockers:

  1. Some responses seem to perform worse, likely due to unnecessarily escaped responses.
  2. Some responses are empty, which causes API's internal TypeError. This error is deterministic and cannot be solved by resending the same prompt.

With that said, we should still adopt Tool API as the previous text-parsing approach is prone to invalid responses format/structure.

@DonggeLiu
Copy link
Collaborator Author

/gcbrun exp -n dg -ag

@DonggeLiu
Copy link
Collaborator Author

/gcbrun exp -n dg -ag

oliverchang
oliverchang reviewed Nov 27, 2024
View reviewed changes
llm_toolkit/models.py Outdated
class GeminiV1D5ChatTool(GeminiV1D5Chat):
"""Gemini 1.5 for chat session that uses tools."""
name = 'vertex_ai_gemini-1-5-chat-tool'
_vertex_ai_model = 'gemini-1.5-pro-001'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not 002?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep will try 002 too.

@DonggeLiu
Copy link
Collaborator Author

DonggeLiu commented Nov 27, 2024 •
edited
Loading

001: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-11-27-731-dg-comparison/index.html
002: https://llm-exp.oss-fuzz.com/Result-reports/ofg-pr/2024-11-28-731-dg-comparison/index.html

@DonggeLiu
Copy link
Collaborator Author

/gcbrun exp -n dg -ag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverchang oliverchang oliverchang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonggeLiu @oliverchang