Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-go-contrib: initial integration #13006

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pellared
Copy link

@pellared pellared commented Feb 4, 2025

Towards open-telemetry/opentelemetry-go-contrib#6605

OpenTelemetry is a collection of APIs, SDKs, and tools to instrument, generate, collect, and export telemetry data (metrics, logs, and traces). It is a CNCF-hosted project that is adopted by companies like eBay, GitHub, Shopify, Skyscanner and many others.

This is adding fuzz tests for https://github.com/open-telemetry/opentelemetry-go-contrib repository.
Here are the current fuzz tests: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/config/v0.3.0/fuzz_test.go

I think it would be good to add https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/config/testdata as corpus, but I would rather do it in a separate PR.

Copy link

github-actions bot commented Feb 4, 2025

pellared is integrating a new project:
- Main repo: https://github.com/open-telemetry/opentelemetry-go-contrib/
- Criticality score: 0.70947

@pellared
Copy link
Author

pellared commented Feb 4, 2025

@AdamKorcz, @DavidKorczynski can you please take look as I see you were working on https://github.com/google/oss-fuzz/tree/master/projects/opentelemetry. I would also appreciate any feedback.

@pellared pellared marked this pull request as ready for review February 4, 2025 13:28
@AdamKorcz
Copy link
Collaborator

Thanks @pellared

Is opentelemetry-contrib interested in this? We have been trying to merge the fuzzers upstream: open-telemetry/opentelemetry-collector-contrib#35715

@pellared
Copy link
Author

pellared commented Feb 4, 2025

Is opentelemetry-contrib interested in this? We have been trying to merge the fuzzers upstream: open-telemetry/opentelemetry-collector-contrib#35715

OpenTelemtry Go and OpenTelemetry Collector are separate components 😉

I am not an approver nor maintainer of OpenTelemetry Collector. However, I guess OpenTelemetry Collector is also interested in this . You can also try pinging on CNCF Slack #otel-collector.

@jonathanmetzman
Copy link
Contributor

Thank you for the integration, are you a maintainer of otel-go-contrib?

@jonathanmetzman
Copy link
Contributor

Thanks, I'm asking the committee about this.

@pellared
Copy link
Author

pellared commented Feb 5, 2025

Thanks, I'm asking the committee about this.

Today, I discovered that we also have one fuzz test in OpenTemetry Go (main repo) here: https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/internal/aggregate/exponential_histogram_test.go

Therefore, I will also want to add a project for it as well.

@AdamKorcz
Copy link
Collaborator

Thanks, I'm asking the committee about this.

Today, I discovered that we also have one fuzz test in OpenTemetry Go (main repo) here: https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/internal/aggregate/exponential_histogram_test.go

Therefore, I will also want to add a project for it as well.

Opentelemetry is currently integrated here which runs the collectors fuzzers: https://github.com/google/oss-fuzz/tree/master/projects/opentelemetry. Could otel-go's fuzzers go in there?

@pellared
Copy link
Author

pellared commented Feb 5, 2025

Thanks, I'm asking the committee about this.

Today, I discovered that we also have one fuzz test in OpenTemetry Go (main repo) here: https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/internal/aggregate/exponential_histogram_test.go
Therefore, I will also want to add a project for it as well.

Opentelemetry is currently integrated here which runs the collectors fuzzers: https://github.com/google/oss-fuzz/tree/master/projects/opentelemetry. Could otel-go's fuzzers go in there?

I have not strong preference. However, I am not sure if it is good to mix projects which have different maintainers and contributors. I leave the decision on you. However, if it is in opentelemetry directory then can I ask you to maintain it? I saw some new "hacks" used in this directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants