-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry-go-contrib: initial integration #13006
base: master
Are you sure you want to change the base?
Conversation
pellared is integrating a new project: |
@AdamKorcz, @DavidKorczynski can you please take look as I see you were working on https://github.com/google/oss-fuzz/tree/master/projects/opentelemetry. I would also appreciate any feedback. |
Thanks @pellared Is opentelemetry-contrib interested in this? We have been trying to merge the fuzzers upstream: open-telemetry/opentelemetry-collector-contrib#35715 |
OpenTelemtry Go and OpenTelemetry Collector are separate components 😉 I am not an approver nor maintainer of OpenTelemetry Collector. However, I guess OpenTelemetry Collector is also interested in this . You can also try pinging on CNCF Slack |
Thank you for the integration, are you a maintainer of otel-go-contrib? |
@jonathanmetzman, yes, I am. See:
I am also a maintainer of OTel Go: |
Thanks, I'm asking the committee about this. |
Today, I discovered that we also have one fuzz test in OpenTemetry Go (main repo) here: https://github.com/open-telemetry/opentelemetry-go/blob/main/sdk/metric/internal/aggregate/exponential_histogram_test.go Therefore, I will also want to add a project for it as well. |
Opentelemetry is currently integrated here which runs the collectors fuzzers: https://github.com/google/oss-fuzz/tree/master/projects/opentelemetry. Could otel-go's fuzzers go in there? |
I have not strong preference. However, I am not sure if it is good to mix projects which have different maintainers and contributors. I leave the decision on you. However, if it is in |
Towards open-telemetry/opentelemetry-go-contrib#6605
OpenTelemetry is a collection of APIs, SDKs, and tools to instrument, generate, collect, and export telemetry data (metrics, logs, and traces). It is a CNCF-hosted project that is adopted by companies like eBay, GitHub, Shopify, Skyscanner and many others.
This is adding fuzz tests for https://github.com/open-telemetry/opentelemetry-go-contrib repository.
Here are the current fuzz tests: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/config/v0.3.0/fuzz_test.go
I think it would be good to add https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/config/testdata as corpus, but I would rather do it in a separate PR.