Skip to content

Commit

Permalink
test(semantic): include ecosystems not supported by lockfile (#1364)
Browse files Browse the repository at this point in the history
Notably this adds coverage over the Ubuntu entry, since that reuses
Debian so we don't have any explicit tests for that in the comparison
tests.

We also no longer need to be manually adding `CRAN` since `lockfile`
supports it
  • Loading branch information
G-Rath authored Nov 4, 2024
1 parent c20dd9f commit f9ac170
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions internal/semantic/parse_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ func TestParse(t *testing.T) {

ecosystems := lockfile.KnownEcosystems()

// todo: remove once CRAN is supported by lockfile
ecosystems = append(ecosystems, "CRAN")
ecosystems = append(ecosystems, "Alpine", "Debian", "Ubuntu")

for _, ecosystem := range ecosystems {
_, err := semantic.Parse("", models.Ecosystem(ecosystem))
Expand All @@ -37,8 +36,7 @@ func TestMustParse(t *testing.T) {

ecosystems := lockfile.KnownEcosystems()

// todo: remove once CRAN is supported by lockfile
ecosystems = append(ecosystems, "CRAN")
ecosystems = append(ecosystems, "Alpine", "Debian", "Ubuntu")

for _, ecosystem := range ecosystems {
semantic.MustParse("", models.Ecosystem(ecosystem))
Expand Down

0 comments on commit f9ac170

Please sign in to comment.