-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(output): update HTML output to a new design #1383
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
- Coverage 69.02% 68.83% -0.20%
==========================================
Files 185 185
Lines 17869 17934 +65
==========================================
+ Hits 12334 12344 +10
- Misses 4876 4925 +49
- Partials 659 665 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome stuff!
I do wonder if it might be worth trying to split this out into at least two PRs as it feels like you're adding a lot of independent stuff, but will leave that for you to decide.
Also, you might already have spotted this but the "overall severity" element isn't responsive:
I know we're not expecting these reports to be viewed on mobile, but I had this occur on my 4k 150%-scaled monitor as I put the report side-by-side (so, half of the resolution) this pr for reviewing
I wanted to split this into separate PRs, but it's a bit challenging. Any code changes would require corresponding changes in other files, and I can't show the outputted HTML without all the features working together. (I can imagine it might be a bit hard to review.)
Yes, that's by design. Implementing dynamic "overall severity" without a frontend framework needs a bit of effort. I also prefer to avoid writing excessive JS code, as it's difficult to review and maintain. If we adopt a framework in the future, this feature will be much easier to implement. So, I think it's not worth to implement it for now.
Good catch! added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick note, can you target this to v2 rather than the base branch?
There are quite a few conflicts. I will merge this into the main and then create a separate PR to merge from main into v2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments, not looking too closely at the HTML, just going to test the functionality for bugs.
Updated (https://hogo6002.github.io/scanner-report/): UI:
Go:
|
Signed-off-by: Holly Gong <[email protected]>
HTML output added #1258
New design (sample one: https://hogo6002.github.io/scanner-report/):
Future plan:
Use frontend framework to enhance code maintainability and readability