Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use single quotes by default in Python scripts #1474

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jan 6, 2025

Apparently I've not been as consistent on this as I thought I was, so as punishment I've gone through all the scripts and made sure they're using single quotes by default - aside from still being used within f strings due to how that syntax works for string literals within interopolations, I have retained the usage of double quotes in four print calls which have single quotes in them to avoid doing an escape

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (6592d02) to head (7a099e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
- Coverage   67.33%   67.31%   -0.03%     
==========================================
  Files         194      194              
  Lines       18354    18361       +7     
==========================================
+ Hits        12359    12360       +1     
- Misses       5325     5329       +4     
- Partials      670      672       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath G-Rath force-pushed the generators/formatting branch from 6f25e42 to 7a099e7 Compare January 6, 2025 00:24
Copy link
Contributor

@hogo6002 hogo6002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@another-rex another-rex merged commit aebdc23 into google:main Jan 8, 2025
21 checks passed
@another-rex another-rex deleted the generators/formatting branch January 8, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants