Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update local matcher to the new requirements for resolve #1481

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

another-rex
Copy link
Collaborator

@another-rex another-rex commented Jan 8, 2025

Sets up logging to only return one error log per database that fails to load, and also adds a LoadEcosystem function to preload/preerror databases

imodels.go part can be safely ignored as that is removed in a followup PR.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 71.05263% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (aebdc23) to head (e18554c).

Files with missing lines Patch % Lines
internal/imodels/imodels.go 57.89% 6 Missing and 2 partials ⚠️
...al/clients/clientimpl/localmatcher/localmatcher.go 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   66.91%   66.91%   -0.01%     
==========================================
  Files         197      197              
  Lines       18621    18619       -2     
==========================================
- Hits        12461    12459       -2     
- Misses       5473     5474       +1     
+ Partials      687      686       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@another-rex another-rex force-pushed the updated-local-client branch from 6c1bffb to e04cf19 Compare January 8, 2025 03:30
Copy link
Member

@michaelkedar michaelkedar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@another-rex another-rex merged commit 61a3731 into google:main Jan 9, 2025
14 checks passed
@another-rex another-rex deleted the updated-local-client branch January 9, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants