Skip to content

Commit

Permalink
pw_build: Update comments around pigweed.bazelrc
Browse files Browse the repository at this point in the history
Copies in some comment updates that were present in Sense but not in
upstream Pigweed so the source of truth is fresh.

Change-Id: Ib933483fb6456fda6e40d2d8d02917da0bcc77ac
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/259293
Docs-Not-Needed: Armando Montanez <[email protected]>
Reviewed-by: Erik Gilling <[email protected]>
Lint: Lint 🤖 <[email protected]>
Pigweed-Auto-Submit: Armando Montanez <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
  • Loading branch information
armandomontanez authored and CQ Bot Account committed Jan 13, 2025
1 parent 00f6395 commit 6053b3c
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions pw_build/pigweed.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,13 @@
# License for the specific language governing permissions and limitations under
# the License.

# Standard Bazel configuration flags required for all Pigweed projects.
# Standard Pigweed flags
# ======================
# All Pigweed projects are expected to set these flags. They mostly pre-adopt
# future Bazel settings, and most are critical to working around known issues.
#
# The source of truth for these flags is @pigweed//pw_build:pigweed.bazelrc in
# the main Pigweed repo.

# Don't automatically create __init__.py files.
#
Expand All @@ -29,7 +35,10 @@ common --repo_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1

# Don't propagate flags or defines to the exec config. This will become the
# default one day (https://github.com/bazelbuild/bazel/issues/22457) and will
# improve cache hit rates between builds targeting different platforms.
# improve cache hit rates between builds targeting different platforms. This is
# especially impactful for large host tools like protoc, which will have its
# cache invalidated when your host C++ config changes, causing many rebuilds
# of protoc (https://pwbug.dev/315871648).
common --experimental_exclude_defines_from_exec_config
common --experimental_exclude_starlark_flags_from_exec_config

Expand Down

0 comments on commit 6053b3c

Please sign in to comment.