Skip to content

Commit

Permalink
pw_toolchain: Cleanup transition flag
Browse files Browse the repository at this point in the history
Removes temporary flag required for updating rules_cc.

Fixes: b/384050813
Change-Id: Ib3d3b41ed10be253acd8bde24a6ae8b2976ca9d0
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/254433
Lint: Lint 🤖 <[email protected]>
Pigweed-Auto-Submit: Armando Montanez <[email protected]>
Reviewed-by: Ted Pudlik <[email protected]>
Presubmit-Verified: CQ Bot Account <[email protected]>
Docs-Not-Needed: Armando Montanez <[email protected]>
Commit-Queue: Auto-Submit <[email protected]>
  • Loading branch information
armandomontanez authored and CQ Bot Account committed Jan 9, 2025
1 parent 78a218f commit df36f07
Showing 1 changed file with 1 addition and 31 deletions.
32 changes: 1 addition & 31 deletions pw_toolchain/host_clang/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -248,38 +248,8 @@ cc_args(
)

cc_feature(
name = "supports_pic_old",
overrides = "@rules_cc//cc/toolchains/features:supports_pic",
tags = ["manual"],
visibility = ["//visibility:private"],
)

# TODO: https://pwbug.dev/384050813 - This flag is a temporary transition flag
# that will be removed shortly.
bool_flag(
name = "new_rules_cc",
build_setting_default = True,
)

config_setting(
name = "rules_cc_post_0.0.10",
flag_values = {
":new_rules_cc": "True",
},
)

cc_feature(
name = "supports_pic_actual",
feature_name = "supports_pic",
visibility = ["//visibility:private"],
)

alias(
name = "supports_pic",
actual = select({
":rules_cc_post_0.0.10": "supports_pic_actual",
"//conditions:default": "supports_pic_old",
}),
feature_name = "supports_pic",
)

# Symlink to clangd, for user convenience.
Expand Down

0 comments on commit df36f07

Please sign in to comment.