This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Python 2.6 compatibility. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still being maintained? I really like this library and would like to contribute, but it's hard to do that with this PR still out. |
Closed
|
Hello @seanfisk , Do you still want to add this support to the pinject? If so, please merge the latest code from the master branch, and make the CI green, then we will be able to merge it. If not, then let's close this PR gracefully. Thank you very much. |
|
My sense is that Py26 should no longer be a target given that Python 2 died on 1/1/2020 (15 months ago). |
|
Agreed with @cclauss, let's prepare to close this PR. If there's anyone wants to keep this PR, please add your reason in the comments before May 1, 2021. If there's no one wants to keep this PR after May 1, then we will close it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should provide Python 2.6 compatibility. I still have two failing tests, but they are failing under 2.7 as well. I'll address those in a later pull request.
With the
unittest2change, I committed a file calledrequirements-dev.txt. You can run this to installunittest2by runningpip install -r requirements-dev.txt.I also plan to apply my Python project template in a later pull request. This should make porting to 3.3 much easier. The project template uses
pytestso I will consider porting the tests topytestwhen I am working on that PR.