Skip to content

Commit

Permalink
Clarify the isSaving comment.
Browse files Browse the repository at this point in the history
  • Loading branch information
techanvil committed Feb 20, 2025
1 parent 488b22d commit 9a03b2a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions assets/js/modules/analytics-4/hooks/useEnableAudienceGroup.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,9 @@ export default function useEnableAudienceGroup( {
},
} );

// Note that we don't set isSaving to false here, this is to ensure that the OAuth error modal doesn't disappear
// when the user clicks the "Retry" button and the page begins to navigate back to the OAuth flow.
// Note that we don't set isSaving to false here, this is to ensure that, when the page begins to navigate to the OAuth flow:
// - The in-progress state for the Audience Segmentation Setup CTA is retained.
// - The OAuth error modal doesn't disappear when it's shown and the user clicks the "Retry" button.
return;
}

Expand Down

0 comments on commit 9a03b2a

Please sign in to comment.