Added a toString, operator == and hashCode to the Quad class. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
reviewed
Jan 25, 2024
spydon
approved these changes
Jan 25, 2024
| @@ -119,8 +119,8 @@ class Vector4 implements Vector { | |||
|
|
|||
| /// Returns a printable string | |||
| @override | |||
| String toString() => '${_v4storage[0]},${_v4storage[1]},' | |||
| '${_v4storage[2]},${_v4storage[3]}'; | |||
| String toString() => '[${_v4storage[0]},${_v4storage[1]},' | |||
There was a problem hiding this comment.
The one in _64 also needs this fix
There was a problem hiding this comment.
it was also fixed in my original commit. Please double check it looks good.
There was a problem hiding this comment.
Ooh, completely missed it when reviewing on the phone. All good then! :)
|
Thanks, pushed fixes. |
johnmccutchan
approved these changes
Jan 25, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jan 30, 2024
… mime, mockito, test, tools, vector_math Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/46d5033..03386ba): 03386ba 2024-01-23 Albert Kaiser Add missing curly braces in README.md (dart-archive/args#261) csslib (https://github.com/dart-lang/csslib/compare/1ad2d1e..ec86ee5): ec86ee5 2024-01-09 Kevin Moore Require Dart 3.0, update and fix lints (dart-archive/csslib#194) ecosystem (https://github.com/dart-lang/ecosystem/compare/1e2785d..9ee08a4): 9ee08a4 2024-01-29 Moritz Add `ignore` flag to health workflows (dart-lang/ecosystem#218) a283d70 2024-01-17 Moritz Make health testable (dart-lang/ecosystem#224) f61a550 2024-01-16 Moritz Enable experiments for health (dart-lang/ecosystem#226) c81f25c 2024-01-16 Moritz Add submodule support to `publish.yaml` (dart-lang/ecosystem#225) b51c356 2024-01-12 Moritz Add submodules support to `health.yaml` (dart-lang/ecosystem#223) d7aaecb 2024-01-10 Moritz Run `health.yaml` for bots (dart-lang/ecosystem#222) 971c733 2024-01-10 Moritz Don't write the failure string when skipping (dart-lang/ecosystem#220) html (https://github.com/dart-lang/html/compare/06bc148..910f6d7): 910f6d7 2024-01-26 Kevin Moore Update lints, require Dart 3.2 (dart-archive/html#236) aaf7d1a 2024-01-25 Kevin Moore blast_repo fixes (dart-archive/html#235) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/ae48489..491f7c6): 491f7c6 2024-01-24 Kevin Moore Update lints, require Dart 3.2 (dart-lang/http_multi_server#63) 0df95e0 2024-01-24 Kevin Moore blast_repo fixes (dart-lang/http_multi_server#62) logging (https://github.com/dart-lang/logging/compare/4d35a4e..e04942d): e04942d 2024-01-18 Kevin Moore update min SDK and deps (dart-archive/logging#155) a03a946 2024-01-18 Craig Labenz Hierarchical logging documentation (dart-archive/logging#146) 439ec80 2024-01-18 Kevin Moore blast_repo fixes (dart-archive/logging#154) mime (https://github.com/dart-lang/mime/compare/ca9f059..99fbdcc): 99fbdcc 2024-01-24 Kevin Moore Update to latest lints, require Dart 3.2 (dart-archive/mime#114) mockito (https://github.com/dart-lang/mockito/compare/e15e000..0422551): 0422551 2024-01-10 Oleh Prypin Ignore "must_be_immutable" warning in generated files. test (https://github.com/dart-lang/test/compare/846d73e..6700049): 6700049d 2024-01-29 Nate Bosch Prepare to publish package:checks (dart-lang/test#2178) a5c4f010 2024-01-24 Nate Bosch Use a raw string for console logging with path (dart-lang/test#2177) fe3102ee 2024-01-10 dependabot[bot] Bump js from 0.6.7 to 0.7.0 in /pkgs/test (dart-lang/test#2168) c709cde0 2024-01-10 Jacob MacDonald fix a bug where test html files were not created in precompiled mode (dart-lang/test#2170) 0eddae47 2024-01-09 Nate Bosch Document the silent reporter (dart-lang/test#2163) tools (https://github.com/dart-lang/tools/compare/8ffc077..f6e67f2): f6e67f2 2024-01-29 Elias Yishak Fix logic for first run to fix `shouldShowMessage` behavior (dart-lang/tools#228) b97bd5c 2024-01-29 Elias Yishak Checking for devtools config file for opt out (dart-lang/tools#227) vector_math (https://github.com/google/vector_math.dart/compare/38a00c3..cb976c7): cb976c7 2024-01-28 Andrew Brampton Update README.md to show how to use vector_math_64. (google/vector_math.dart#312) d99c903 2024-01-25 Andrew Brampton Added a toString, operator == and hashCode to the Quad class. (google/vector_math.dart#311) Change-Id: Ie42ec078b7b4d408d5167e38f05f1f37b754afb0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349301 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and minor fix to the vector4 toString