fix: additional process.kill fallback for bun (#770)

oven-sh/bun#8787
google · Apr 6, 2024 · 5ad9ce3 · 5ad9ce3
1 parent e010f23
commit 5ad9ce3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -53,14 +53,14 @@
   },
   "optionalDependencies": {
     "@types/fs-extra": "^11.0.4",
-    "@types/node": ">=20.12.4"
+    "@types/node": ">=20.12.5"
   },
   "devDependencies": {
     "@types/fs-extra": "^11.0.4",
     "@types/minimist": "^1.2.5",
     "@types/node": ">=20.11.30",
     "@types/which": "^3.0.3",
-    "@webpod/ps": "^0.0.0-beta.2",
+    "@webpod/ps": "^0.0.0-beta.3",
     "@webpod/ingrid": "^0.0.0-beta.3",
     "c8": "^9.1.0",
     "chalk": "^5.3.0",

diff --git a/src/core.ts b/src/core.ts
@@ -589,7 +589,11 @@ export async function kill(pid: number, signal?: string) {
   }
   try {
     process.kill(-pid, signal)
-  } catch (e) {}
+  } catch (e) {
+    try {
+      process.kill(+pid, signal)
+    } catch (e) {}
+  }
 }
 
 export type LogEntry =