feat: set $.verbose to false by default

closes #569
google · Mar 27, 2024 · 9b33231 · 9b33231
1 parent 6234c13
commit 9b33231
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 26 deletions.
diff --git a/src/core.ts b/src/core.ts
@@ -83,7 +83,7 @@ hook.enable()
 export const defaults: Options = {
   [processCwd]: process.cwd(),
   [syncExec]: false,
-  verbose: true,
+  verbose: false,
   env: process.env,
   sync: false,
   shell: true,

diff --git a/test/cli.test.js b/test/cli.test.js
@@ -21,7 +21,6 @@ describe('cli', () => {
   let promiseResolved = false
 
   beforeEach(() => {
-    $.verbose = false
     process.on('exit', () => {
       if (!promiseResolved) {
         console.error('Error: ProcessPromise never resolved.')

diff --git a/test/core.test.js b/test/core.test.js
@@ -21,10 +21,6 @@ import { ProcessPromise, ProcessOutput } from '../build/index.js'
 import '../build/globals.js'
 
 describe('core', () => {
-  beforeEach(() => {
-    $.verbose = false
-  })
-
   test('only stdout is used during command substitution', async () => {
     let hello = await $`echo Error >&2; echo Hello`
     let len = +(await $`echo ${hello} | wc -c`)
@@ -340,7 +336,6 @@ describe('core', () => {
       resolve()
     }
 
-    $.verbose = false
     assert.equal($.verbose, false)
 
     within(() => {
@@ -364,7 +359,6 @@ describe('core', () => {
     let pwd = await $`pwd`
 
     within(async () => {
-      $.verbose = false
       cd('/tmp')
       setTimeout(async () => {
         assert.ok((await $`pwd`).stdout.trim().endsWith('/tmp'))

diff --git a/test/deps.test.js b/test/deps.test.js
@@ -18,10 +18,6 @@ import { $ } from '../build/index.js'
 import { installDeps, parseDeps } from '../build/deps.js'
 
 describe('deps', () => {
-  beforeEach(() => {
-    $.verbose = false
-  })
-
   test('installDeps() loader works via JS API', async () => {
     await installDeps({
       cpy: '9.0.1',

diff --git a/test/experimental.test.js b/test/experimental.test.js
@@ -15,8 +15,4 @@
 import { describe, before } from 'node:test'
 import '../build/globals.js'
 
-describe('experimental', () => {
-  before(() => {
-    $.verbose = false
-  })
-})
+describe('experimental', () => {})
diff --git a/test/goods.test.js b/test/goods.test.js
@@ -18,10 +18,6 @@ import { test, describe, beforeEach } from 'node:test'
 import '../build/globals.js'
 
 describe('goods', () => {
-  beforeEach(() => {
-    $.verbose = false
-  })
-
   function zx(script) {
     return $`node build/cli.js --eval ${script}`.nothrow().timeout('5s')
   }

diff --git a/test/package.test.js b/test/package.test.js
@@ -18,7 +18,6 @@ import '../build/globals.js'
 
 describe('package', () => {
   beforeEach(async () => {
-    $.verbose = false
     const pack = await $`npm pack`
     await $`tar xf ${pack}`
     await $`rm ${pack}`.nothrow()

diff --git a/test/win32.test.js b/test/win32.test.js
@@ -19,10 +19,6 @@ import '../build/globals.js'
 const _describe = process.platform === 'win32' ? describe : describe.skip
 
 _describe('win32', () => {
-  beforeEach(() => {
-    $.verbose = false
-  })
-
   test('should work with windows-specific commands', async () => {
     const p = await $`echo $0` // Bash is first by default.
     assert.match(p.stdout, /bash/)