Add minute support in duration (#703) (#704)

* Add minute support for parseDuration * Add minute to Duration type * Fix formatting issue of Duration type in util.ts * Add test for minute in duration parsing --------- Co-authored-by: Anton Medvedev <[email protected]>
google · Mar 28, 2024 · b02fd52 · b02fd52
1 parent 8a7a8fe
commit b02fd52
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/util.ts b/src/util.ts
@@ -216,7 +216,7 @@ export function errnoMessage(errno: number | undefined): string {
   )
 }
 
-export type Duration = number | `${number}s` | `${number}ms`
+export type Duration = number | `${number}m` | `${number}s` | `${number}ms`
 
 export function parseDuration(d: Duration) {
   if (typeof d == 'number') {
@@ -226,6 +226,8 @@ export function parseDuration(d: Duration) {
     return +d.slice(0, -1) * 1000
   } else if (/\d+ms/.test(d)) {
     return +d.slice(0, -2)
+  } else if (/\d+m/.test(d)) {
+    return +d.slice(0, -1) * 1000 * 60
   }
   throw new Error(`Unknown duration: "${d}".`)
 }

diff --git a/test/util.test.js b/test/util.test.js
@@ -67,6 +67,7 @@ describe('util', () => {
     assert.equal(parseDuration(1000), 1000)
     assert.equal(parseDuration('2s'), 2000)
     assert.equal(parseDuration('500ms'), 500)
+    assert.equal(parseDuration('2m'), 120000)
     assert.throws(() => parseDuration('100'))
     assert.throws(() => parseDuration(NaN))
     assert.throws(() => parseDuration(-1))