Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable stream picking on pipe() #1023

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

antongolub
Copy link
Collaborator

Closes #978

  const p = $`echo foo >&2; echo bar`
  const o1 = (await p.pipe.stderr`cat`).toString()
  const o2 = (await p.pipe.stdout`cat`).toString()
  
  assert.equal(o1, 'foo\n')
  assert.equal(o2, 'bar\n')
  • Tests pass
  • Appropriate changes to README are included in PR

@antongolub antongolub changed the title feat: enable stream pointing on pipe() feat: enable stream picking on pipe() Dec 23, 2024
@antongolub antongolub requested a review from antonmedv December 23, 2024 15:11
@antongolub antongolub merged commit 999db3d into google:main Dec 23, 2024
19 checks passed
@antongolub antongolub deleted the pick-stream-on-pipe branch December 23, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: apply promisifyStream to ProcessPromise exposed streams
2 participants