-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add usePwsh
helper for PowerShell v7+
#790
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Fixed smoke test to use Added Fixed formatting. |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ShGKme, thanks for the improvement. Could you also verify the snapshot [email protected]? |
✅ Verified
|
Fixes #785
Notes
No documentation was added. I haven't found any documentation for other helpers apart from release notes...
A smoke test was added to
win32
test but I'm not sure if it's a good idea.pwsh
is not available by defaultpwsh
can be used on any supported platformSo the last commit can be dropped. Or I can create a new smoke test.
Description
A new helper
usePwsh
to usepwsh
shell (PowerShell v7+).Usage
Tested on Windows 11 and Fedora 38