Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move docs to main branch #969 #985

Merged
merged 9 commits into from
Dec 17, 2024
Merged

docs: move docs to main branch #969 #985

merged 9 commits into from
Dec 17, 2024

Conversation

1e9y
Copy link
Contributor

@1e9y 1e9y commented Dec 14, 2024

Moving documentation from the gh-pages branch to main branch to keep it closer to the sources. What I have done in this PR:

  • Amended docs workflow to trigger on new release event.
  • Moved Vitepress configuration from branch (root) to main (docs folder)
  • Added relevant package.json commands
  • Moved all doc sources to main

Fixes #969

  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

google-cla bot commented Dec 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@1e9y
Copy link
Contributor Author

1e9y commented Dec 14, 2024

@antonmedv Can you please confirm that this solution aligns with your idea?

export default defineConfig({
ignoreDeadLinks: true,
base: '/zx/',
outDir: 'docs',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does mean, that <root>/docs/docs will be created, while Upload artifact step is still referencing to <root>/docs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rename it to build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, @antongolub. I renamed the artifact directory to build, as @antonmedv suggested, and amended workflow file and Vitepress configuration accordingly.

@1e9y 1e9y changed the title Scaffold moving docs from gh-pages to main #969 Move docs to main branch #969 Dec 15, 2024
@antongolub antongolub added the ossln24 OSS Library Night 2024 label Dec 15, 2024
@antongolub
Copy link
Collaborator

antongolub commented Dec 16, 2024

@1e9y

https://github.com/google/zx/actions/runs/12357969325/job/34491188714?pr=985
No idea what exactly is broken, but my first steps for similar cases: rm -rf node_modules package-lock.json && npm i
And rebase plz.

@1e9y 1e9y changed the title Move docs to main branch #969 docs: move docs to main branch #969 Dec 16, 2024
@1e9y
Copy link
Contributor Author

1e9y commented Dec 17, 2024

@antongolub

My latest commit has a green tick. But it didn't run the workflow for some reason... I guess one of you must approve it.

Copy link
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@antongolub antongolub merged commit 3e5bcb0 into google:main Dec 17, 2024
21 checks passed
@antongolub
Copy link
Collaborator

@1e9y ,
Thanks for the contribution. Now you're able to update your gh profile badges to get the reward.

@1e9y 1e9y deleted the docs branch December 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ossln24 OSS Library Night 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: bring the docs closer to sources
3 participants