-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move docs to main
branch #969
#985
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@antonmedv Can you please confirm that this solution aligns with your idea? |
docs/.vitepress/config.mts
Outdated
export default defineConfig({ | ||
ignoreDeadLinks: true, | ||
base: '/zx/', | ||
outDir: 'docs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does mean, that <root>/docs/docs
will be created, while Upload artifact step is still referencing to <root>/docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets rename it to build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, @antongolub. I renamed the artifact directory to build
, as @antonmedv suggested, and amended workflow file and Vitepress configuration accordingly.
gh-pages
to main
#969main
branch #969
https://github.com/google/zx/actions/runs/12357969325/job/34491188714?pr=985 |
main
branch #969main
branch #969
My latest commit has a green tick. But it didn't run the workflow for some reason... I guess one of you must approve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good.
@1e9y , |
Moving documentation from the
gh-pages
branch tomain
branch to keep it closer to the sources. What I have done in this PR:docs
workflow to trigger on new release event.docs
folder)package.json
commandsFixes #969