Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for PHP 8.4 #1059

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Added support for PHP 8.4 #1059

merged 1 commit into from
Dec 12, 2024

Conversation

fiboknacky
Copy link
Member

  • Regenerated source code to suppress the deprecation warnings.
  • Updated src/Google/Ads/GoogleAds/Lib/InsecureCredentialsWrapper.php to be compatible with the latest version of GAX.

Bug: N/A

- Regenerated source code to suppress the deprecation warnings.
- Updated src/Google/Ads/GoogleAds/Lib/InsecureCredentialsWrapper.php.

Bug: N/A
Change-Id: I4e97e7a20cc2c705d1c360c7c481cbfc8779e01f
@fiboknacky fiboknacky requested a review from Raibaz December 12, 2024 07:22
@fiboknacky
Copy link
Member Author

This is also the fix for #1056.

@fiboknacky fiboknacky merged commit aa08607 into main Dec 12, 2024
2 checks passed
@fiboknacky fiboknacky deleted the support-php84 branch December 12, 2024 17:34
fiboknacky added a commit that referenced this pull request Dec 13, 2024
- Regenerated source code to suppress the deprecation warnings.
- Updated src/Google/Ads/GoogleAds/Lib/InsecureCredentialsWrapper.php.

Bug: N/A
fiboknacky added a commit that referenced this pull request Dec 13, 2024
* Added support for PHP 8.4. (#1059)

- Regenerated source code to suppress the deprecation warnings.
- Updated src/Google/Ads/GoogleAds/Lib/InsecureCredentialsWrapper.php.

* Updated InfoRedactor to remove non PHP 7.4 code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants