Apply suggestions from code review

googleapis · Nov 6, 2024 · 8d03965 · lcobucci · Nov 12, 2024 · bshaffer
1 parent 392023b
commit 8d03965
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 21 deletions.
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
@@ -19,5 +19,5 @@ jobs:
         uses: GoogleCloudPlatform/php-tools/.github/workflows/doctum.yml@main
         with:
           title: "Google API Core (GAX) Reference Documentation"
-          default_version: ${{ inputs.tag || github.head_ref || github.event.pull_request.head.repo.full_name }}
+          default_version: ${{ inputs.tag || github.head_ref || github.ref_name }}
           dry_run: ${{ github.event_name == 'pull_request' }}
diff --git a/src/GapicClientTrait.php b/src/GapicClientTrait.php
@@ -218,8 +218,6 @@ protected function getCredentialsWrapper()
      */
     private function setClientOptions(array $options)
     {
-        $hasEmulator = $options['hasEmulator'] ?? false;
-
         // serviceAddress is now deprecated and acts as an alias for apiEndpoint
         if (isset($options['serviceAddress'])) {
             $options['apiEndpoint'] = $this->pluck('serviceAddress', $options, false);
@@ -316,7 +314,7 @@ private function setClientOptions(array $options)
                 $transport,
                 $options['transportConfig'],
                 $options['clientCertSource'],
-                $hasEmulator
+                $options['hasEmulator'] ?? false
             );
     }
 

diff --git a/src/InsecureRequestBuilder.php b/src/InsecureRequestBuilder.php
@@ -10,30 +10,18 @@
  */
 class InsecureRequestBuilder extends RequestBuilder
 {
-    /**
-     * @param string $baseUri
-     * @param string $restConfigPath
-     * @throws ValidationException
-     */
-    public function __construct(string $baseUri, string $restConfigPath)
-    {
-        parent::__construct($baseUri, $restConfigPath);
-    }
-
     /**
      * @param string $path
      * @param array $queryParams
      * @return UriInterface
      */
     protected function buildUri(string $path, array $queryParams)
     {
-        $uri = Utils::uriFor(
-            sprintf(
-                'http://%s%s',
-                $this->baseUri,
-                $path
-            )
-        );
+        $uri = Utils::uriFor(sprintf(
+            'http://%s%s',
+            $this->baseUri,
+            $path
+        ));
         if ($queryParams) {
             $uri = $this->buildUriWithQuery(
                 $uri,