Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing withResponseMetadata option #606

Closed
wants to merge 1 commit into from

Conversation

ujwaldhakal
Copy link

The withResponseMetadata option was missing from this library https://github.com/googleads/google-ads-php/blob/main/src/Google/Ads/GoogleAds/Lib/V17/UnaryGoogleAdsResponseMetadataCallable.php\#L48 because it was using gax-php.

A discussion ticket has been opened here googleads/google-ads-php#1050

@ujwaldhakal ujwaldhakal requested review from a team as code owners December 11, 2024 11:11
Copy link

google-cla bot commented Dec 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bshaffer
Copy link
Contributor

@ujwaldhakal the withResponseMetadata option is not supported in GAX, or in any GAPIC library as far as I know - it may be supported as a custom option by Google Ads. If that's the case, we'll need to figure out how to accommodate it.

@bshaffer
Copy link
Contributor

@bshaffer bshaffer closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants