feat: Add context object to pass to supplier functions #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpassing
reviewed
Jan 31, 2024
oauth2_http/java/com/google/auth/oauth2/IdentityPoolSubjectTokenSupplier.java
Show resolved
Hide resolved
product-auto-label
bot
added
size: l
lsirac
requested changes
Feb 1, 2024
oauth2_http/java/com/google/auth/oauth2/ExternalAccountSupplierContext.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountSupplierContext.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountSupplierContext.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountSupplierContext.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountSupplierContext.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountSupplierContext.java
Outdated
Show resolved
Hide resolved
lsirac
requested changes
Feb 2, 2024
oauth2_http/java/com/google/auth/oauth2/ExternalAccountSupplierContext.java
Show resolved
Hide resolved
westarle
approved these changes
Feb 2, 2024
lsirac
approved these changes
Feb 2, 2024
oauth2_http/java/com/google/auth/oauth2/ExternalAccountSupplierContext.java
Show resolved
Hide resolved
|
TimurSadykov
reviewed
Feb 5, 2024
| @@ -0,0 +1,100 @@ | |||
| package com.google.auth.oauth2; | |||
There was a problem hiding this comment.
Add a copyright header?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds context object to pass from credentials to user defined suppliers.