Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove Base64 padding in DefaultPKCEProvider #1375

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix: Remove Base64 padding in DefaultPKCEProvider #1375

merged 2 commits into from
Mar 14, 2024

Conversation

clundin25
Copy link
Contributor

Fixes
#1373.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@clundin25 clundin25 requested a review from a team as a code owner March 11, 2024 18:30
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 11, 2024
@clundin25 clundin25 requested a review from TimurSadykov March 11, 2024 18:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@clundin25 clundin25 mentioned this pull request Mar 11, 2024
Closed
@clundin25
Copy link
Contributor Author

@TimurSadykov ping :D

TimurSadykov
TimurSadykov approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@clundin25 clundin25 merged commit 1405378 into googleapis:main Mar 14, 2024
18 checks passed
@release-please release-please bot mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimurSadykov TimurSadykov TimurSadykov approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clundin25 @TimurSadykov