build: improve logic for issue template closing and add tests #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcf-owl-bot
bot
removed
the
owlbot:run
…node into updateBugReport
…node into updateBugReport
…node into updateBugReport
danieljbruce
approved these changes
Jan 15, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was meant to only be to add better logic and testing for our issue automation since it was looking a little fragile, see #5838. I also will follow up for our split libraries, see googleapis/synthtool#2052
However, it also includes some changes that were incorrectly added to the library, namely #5914, #5381, #5922. The more permanent fixes will come in a new version of the generator, and cl/715614266.
The only relevant changes to review are in .github folder