Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency gts to v5 - autoclosed #139

Closed
wants to merge 1 commit into from

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 1, 2023

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
gts ^3.1.0 -> ^5.0.0 age adoption passing confidence

Release Notes

google/gts (gts)

v5.3.1

Compare Source

Bug Fixes
  • deps: replace dependency eslint-plugin-node with eslint-plugin-n (#​865) (efbe3a8)
  • deps: update dependency eslint to v8.57.0 (#​833) (0c0a45c)
  • deps: update dependency prettier to v3.2.5 (#​846) (7e60e38)
Performance Improvements
  • Supercharge Performance & Efficiency: Leveraging Promise.all for Resource-Friendly Tasks 🚤 (#​838) (7424fe1)

v5.3.0

Compare Source

Features
Bug Fixes

v5.2.0

Compare Source

Features

v5.1.1

Compare Source

Bug Fixes
  • revert feat: no-floating-promises (44de7f7)

v5.1.0

Compare Source

Features
Bug Fixes

v5.0.1

Compare Source

Bug Fixes
  • line up linting with owlbot post-processing linting (#​778) (a731fe9)

v5.0.0

Compare Source

⚠ BREAKING CHANGES
  • Upgrade to node 14 as the minimum version (#​771)
Bug Fixes
Miscellaneous Chores

v4.0.1

Compare Source

Bug Fixes

v4.0.0

Compare Source

⚠ BREAKING CHANGES
  • drop support for node.js 10.x (#​686)
Features
Bug Fixes
Build System

Configuration

📅 Schedule: Branch creation - "every 3 months on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner October 1, 2023 00:48
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2023
@product-auto-label product-auto-label bot added the api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. label Oct 1, 2023
@rogerthatdev
Copy link

This update to gts introduces a failure on npm run check (which runs gts check):

  226:41  error  This number literal will lose precision at runtime  @typescript-eslint/no-loss-of-precision

Offending line in tests/index.ts:

        firebase_screen_id: {intValue: -2415111648950109400},

The value here is beyond the range of an int (between -2,147,483,647 and 2,147,483,647)

The following could resolve the error:

  • increasing the firebase_screen_id value to be within the range
  • changing the value frointValue to stringValue
  • Skipping the check

@rogerthatdev
Copy link

rogerthatdev commented Nov 30, 2023

Added to the branch of this PR: a skip for the no-loss-of-precision check.

Remaining error on version 12 and 10:

v10:

TypeError: Module.createRequire is not a function
    at Object.<anonymous> (/home/runner/work/google-cloudevents-nodejs/google-cloudevents-nodejs/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2395:26)
    at Module._compile (internal/modules/cjs/[loader.js:778:30](about:blank))
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/runner/work/google-cloudevents-nodejs/google-cloudevents-nodejs/node_modules/eslint/lib/cli-engine/cli-engine.js:33:5)
    at Module._compile (internal/modules/cjs/loader.js:778:30)

v12:

Error: Cannot find module 'node:fs'
Require stack:
- /home/runner/work/google-cloudevents-nodejs/google-cloudevents-nodejs/node_modules/synckit/lib/index.cjs
- /home/runner/work/google-cloudevents-nodejs/google-cloudevents-nodejs/node_modules/eslint-plugin-prettier/eslint-plugin-prettier.js
- /home/runner/work/google-cloudevents-nodejs/google-cloudevents-nodejs/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
Occurred while linting /home/runner/work/google-cloudevents-nodejs/google-cloudevents-nodejs/cloud/audit/v1/LogEntryData.ts:20
Rule: "prettier/prettier"
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:8[15](https://github.com/googleapis/google-cloudevents-nodejs/actions/runs/7039705706/job/19160030943?pr=139#step:6:16):15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:[18](https://github.com/googleapis/google-cloudevents-nodejs/actions/runs/7039705706/job/19160030943?pr=139#step:6:19))
    at Object.<anonymous> (/home/runner/work/google-cloudevents-nodejs/google-cloudevents-nodejs/node_modules/synckit/lib/index.cjs:5:10)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:[19](https://github.com/googleapis/google-cloudevents-nodejs/actions/runs/7039705706/job/19160030943?pr=139#step:6:20))

@rogerthatdev rogerthatdev self-requested a review November 30, 2023 01:33
@rogerthatdev rogerthatdev self-assigned this Nov 30, 2023
@glasnt
Copy link

glasnt commented Dec 11, 2023

gts 4.0 drops support for node 10, and gts 5 for node 12. https://github.com/google/gts/blob/HEAD/CHANGELOG.md#500-2023-07-26, and this repo currently runs tests in 10, 12, and 14 https://github.com/googleapis/google-cloudevents-nodejs/blob/ca78ed72533b9823693811b52f31c22bc9e46ef0/.github/workflows/lint.yaml which might explain the additional lint errors in 10 and 12.

The firebase_screen_id comes from https://github.com/googleapis/google-cloudevents/blob/main/testdata/google/events/firebase/analytics/v1/AnalyticsLogData-complex.json#L81, so the source of that may need to be updated as well (pending what values are valid to use here, types, etc)

@rogerthatdev rogerthatdev removed their assignment Jan 2, 2024
@renovate-bot renovate-bot force-pushed the renovate/gts-5.x branch 2 times, most recently from 89369b9 to f7ac82f Compare June 17, 2024 21:52
@renovate-bot renovate-bot changed the title chore(deps): update dependency gts to v5 chore(deps): update dependency gts to v5 - autoclosed Oct 15, 2024
@renovate-bot renovate-bot deleted the renovate/gts-5.x branch October 15, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: eventarc Issues related to the googleapis/google-cloudevents-nodejs API. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants