GenericUrl: improve the error message for malformed URLs #1486
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's say by mistake we pass a malformed URL to the constructor of
GenericUrl
.Previously the line above used to throw the following exception:
Not very helpful.
Whereas with this patch:
The exception thrown now clearly shows what was the faulty URL.
The user can therefore quickly figure out which URL needs to be fixed.
A lesson I learned today :)