-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kafka migration #330
Conversation
migration/docker/Dockerfile
Outdated
ARG BUILD_PUBSUB_LITE_JOB_FILE="PSL_job.json" | ||
ENV KAFKA_HEAP_OPTS="-Xms2G -Xmx2G" | ||
ENV KAFKA_HOME="${KAFKA_HOME_ROOT}/kafka" | ||
ARG KAFKA_PLUGINS_DIR="${KAFKA_HOME}/plugins" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move KAFKA_ related ARG together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes broadly look good but I'm wondering if the migration/ folder itself needs to live in this project. This repo is mostly used for self-managed deployments.
LGTM |
Adds the tooling to support migrating a PubSub lite topic to a Managed Kafka topic