Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kafka migration #330

Merged
merged 5 commits into from
Jun 18, 2024
Merged

feat: add kafka migration #330

merged 5 commits into from
Jun 18, 2024

Conversation

johnjcasey
Copy link
Contributor

Adds the tooling to support migrating a PubSub lite topic to a Managed Kafka topic

@johnjcasey johnjcasey requested review from a team as code owners June 14, 2024 12:56
migration/docker/Dockerfile Show resolved Hide resolved
migration/docker/Dockerfile Outdated Show resolved Hide resolved
migration/docker/Dockerfile Outdated Show resolved Hide resolved
ARG BUILD_PUBSUB_LITE_JOB_FILE="PSL_job.json"
ENV KAFKA_HEAP_OPTS="-Xms2G -Xmx2G"
ENV KAFKA_HOME="${KAFKA_HOME_ROOT}/kafka"
ARG KAFKA_PLUGINS_DIR="${KAFKA_HOME}/plugins"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move KAFKA_ related ARG together.

migration/docker/Dockerfile Show resolved Hide resolved
migration/docker/Dockerfile Show resolved Hide resolved
migration/k8s.yaml Show resolved Hide resolved
Copy link
Contributor

@samarthsingal samarthsingal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes broadly look good but I'm wondering if the migration/ folder itself needs to live in this project. This repo is mostly used for self-managed deployments.

@rajanya-google
Copy link
Member

LGTM

@hannahrogers-google hannahrogers-google added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 18, 2024
@hannahrogers-google hannahrogers-google changed the title Add kafka migration feat: add kafka migration Jun 18, 2024
@johnjcasey johnjcasey merged commit 58e7555 into main Jun 18, 2024
14 of 17 checks passed
@johnjcasey johnjcasey deleted the add-kafka-migration branch June 18, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants