Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: unmanaged dependencies check #1603

Merged
merged 3 commits into from
Mar 4, 2024
Merged

ci: unmanaged dependencies check #1603

merged 3 commits into from
Mar 4, 2024

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Feb 21, 2024 •
edited
Loading

b/320677251 and go/cloud-sdk-java-dependency-governance-design which Hannah reviewed the idea.

@suztomo suztomo requested review from a team as code owners February 21, 2024 18:00
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsublite Issues related to the googleapis/java-pubsublite API. labels Feb 21, 2024
@suztomo
Copy link
Member Author

suztomo commented Feb 21, 2024

"Unmanaged dependency check / unmanaged_dependency_check" failed https://github.com/googleapis/java-pubsublite/actions/runs/7993506408/job/21829477327?pr=1603

Running Unmanaged Dependency Check against /home/runner/work/java-pubsublite/java-pubsublite/google-cloud-pubsublite-bom/pom.xml This pull request seems to add new third-party dependency, [com.google.flogger:flogger, com.google.flogger:flogger-system-backend, com.google.flogger:google-extensions], among the artifacts listed in google-cloud-pubsublite-bom/pom.xml.

@suztomo suztomo marked this pull request as draft February 21, 2024 18:06
@suztomo suztomo mentioned this pull request Mar 4, 2024
Merged
1 task
@suztomo
Copy link
Member Author

suztomo commented Mar 4, 2024 •
edited
Loading

With the upgraded shared dependencies (#1608), now the build succeeds: Unmanaged dependency check / unmanaged_dependency_check (pull_request) Successful

@suztomo suztomo marked this pull request as ready for review March 4, 2024 20:41
@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Mar 4, 2024
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7a239be into main Mar 4, 2024
24 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the unmanaged_dependency_check branch March 4, 2024 22:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suztomo @hannahrogers-google