Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore google-cloud-pubsublite-bom package #1771

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: restore google-cloud-pubsublite-bom package #1771

merged 1 commit into from
Oct 31, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Oct 31, 2024 •
edited
Loading

BEGIN_COMMIT_OVERRIDE
fix: restore google-cloud-pubsublite-bom package
END_COMMIT_OVERRIDE

The google-cloud-pubsublite-bom is used in the libraries-bom: https://github.com/googleapis/java-cloud-bom/blob/2c49bcfe0a415e8255a7c9b3cc94951177a1da92/google-cloud-bom/pom.xml#L234 and causing the following failure in the shared-dependencies convergence check:

Found 1 artifacts with shared dependencies version: 3.37.0
Warning: cloud-pubsublite:1.14.4[WARNING] 
java.lang.RuntimeException: Failed to converge dependencies
    at com.google.cloud.tools.opensource.cloudbomdashboard.DashboardMain.main (DashboardMain.java:114)
    at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:254)
    at java.lang.Thread.run (Thread.java:750)

This artifact seems to have been removed unintentionally in #1748

@mpeddada1 mpeddada1 requested review from a team as code owners October 31, 2024 01:26
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsublite Issues related to the googleapis/java-pubsublite API. labels Oct 31, 2024
@mpeddada1 mpeddada1 changed the title chore: restore google-cloud-pubsublite-bom package fix: restore google-cloud-pubsublite-bom package Oct 31, 2024
@bcol-google bcol-google merged commit d147df5 into main Oct 31, 2024
23 checks passed
@bcol-google bcol-google deleted the pubsublite-bom-release branch October 31, 2024 15:28
@mpeddada1 mpeddada1 added the release-please:force-run To run release-please label Oct 31, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@bcol-google bcol-google Awaiting requested review from bcol-google

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpeddada1 @suztomo @bcol-google