Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix timestamp drift due to using instanceof typeguard #827

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Fix timestamp drift due to using instanceof typeguard #827

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb3022
fix: Fix timestamp drift due to prototype comparison
Nov 6, 2023
2e5b902
Merge branch 'main' into cindy/nodejs-logging-winston
cindy-peng Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ export class LoggingCommon {
// metadata. As Winston 3 buffers logs when a transport (such as this one)
// invokes its log callback asynchronously, a timestamp assigned at log time
// is more accurate than one assigned in a transport.
if (metadata.timestamp instanceof Date) {
Copy link
Contributor Author

@cindy-peng cindy-peng Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typeguard is preventing customer metadata timestamp to be properly assigned to entry metadata. Considering entryMetadata is expecting a union type Timestamp | null | undefined, I think it is not necessary for us to force a Date type to be checked and assigned.

if (metadata.timestamp) {
entryMetadata.timestamp = metadata.timestamp;
}

Expand Down