Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix trace_sampled type to be consistent with API documentation #830

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

cindy-peng
Copy link
Contributor

@cindy-peng cindy-peng commented Nov 13, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #802 🦕
This is to fix the expected type and value for trace_sampled to be consistent with the documentation. According to the LogEntry API documentation, trace_sampled is expected to be a bool type. This has also been correctly documented in the logging-winston homepage.

@cindy-peng cindy-peng requested review from a team as code owners November 13, 2023 19:01
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 13, 2023
@product-auto-label product-auto-label bot added api: logging Issues related to the googleapis/nodejs-logging-winston API. samples Issues that are directly related to samples. labels Nov 13, 2023
@cindy-peng cindy-peng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2023
@cindy-peng cindy-peng merged commit 33103dc into main Nov 15, 2023
18 checks passed
@cindy-peng cindy-peng deleted the cindy/fix-logging-sample-key branch November 15, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging-winston API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry issues; timestamp drift, and LOGGING_SAMPLED_KEY is not treated as boolean
4 participants