Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix comment typo in logging common class #834

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Fix comment typo in logging common class #834

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf649cb
Fix typo
benjaminfiliatrault Jan 17, 2024
3053d15
Merge branch 'main' into main
benjaminfiliatrault Jan 23, 2024
87afcd4
Merge branch 'main' into main
benjaminfiliatrault Feb 25, 2024
93ba808
Merge branch 'main' into main
benjaminfiliatrault Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ export class LoggingCommon {
}
// In case if original error was null and callback thrown exception, rethrow it to make sure
// we do not swallow it since upon success the exceptions normally should not be thrown. Also
// we should retrhrow callbackError when defaultCallback was not provided to keep
// we should rethrow callbackError when defaultCallback was not provided to keep
// prevous behaviour intact
if ((!this.defaultCallback || err === null) && callbackError) {
throw callbackError;
Expand Down