Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: setup release-please to update generator version in generation configuration #2819

Merged
merged 2 commits into from
May 24, 2024
Merged

chore: setup release-please to update generator version in generation configuration #2819

merged 2 commits into from
May 24, 2024

Conversation

JoeWang1127
Copy link
Collaborator

@JoeWang1127 JoeWang1127 commented May 24, 2024 •
edited
Loading

In this PR:

  • Setup release-please to update the generator version in the generation_config.yaml.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 24, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review May 24, 2024 19:38
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner May 24, 2024 19:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 merged commit 29abcfd into main May 24, 2024
46 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/update-generator-version branch May 24, 2024 19:52
blakeli0
blakeli0 approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As a follow up, let's investigate if we can get rid of the gapic_generator_version from the generation_config.yaml, otherwise we would always have to build it locally and volumn .m2 folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang1127 @blakeli0 @diegomarquezp