Handle unexpected status errors (#101)

CHANGELOG.md

@@ -1,3 +1,6 @@
+## 0.10.0 (2018-09-21)
+* Add UnexpectedStatusError class for http status errors that are not handled.
+
 ## 0.9.2 (2018-09-12)
 * Update issued_at correctly when it is set simultaneously with expires_in.
 

lib/signet/errors.rb

@@ -39,6 +39,11 @@ class MalformedAuthorizationError < StandardError
   class RemoteServerError < StandardError
   end
 
+  ##
+  # An error indicating that the server sent an unexpected http status
+  class UnexpectedStatusError < StandardError
+  end
+
   ##
   # An error indicating the remote server refused to authorize the client.
   class AuthorizationError < StandardError

lib/signet/oauth_2/client.rb

@@ -1006,9 +1006,7 @@ def fetch_access_token(options={})
           if body.to_s.strip.length > 0
             message += "  Server message:\n#{response.body.to_s.strip}"
           end
-          raise ::Signet::AuthorizationError.new(
-            message, :response => response
-          )
+          raise ::Signet::UnexpectedStatusError.new(message)
         end
       end
 

lib/signet/version.rb

@@ -17,8 +17,8 @@
   module Signet
     module VERSION
       MAJOR = 0
-      MINOR = 9
-      TINY  = 2
+      MINOR = 10
+      TINY  = 0
       PRE   = nil
 
       STRING = [MAJOR, MINOR, TINY, PRE].compact.join('.')

spec/signet/oauth_2/client_spec.rb

@@ -589,7 +589,7 @@ def build_form_encoded_response(payload)
     stubs.verify_stubbed_calls
   end
 
-  it 'should raise an error if the token server gives an unexpected status' do
+  it 'should raise an unexpected error if the token server gives an unexpected status' do
     @client.client_id = 'client-12345'
     @client.client_secret = 'secret-12345'
     stubs = Faraday::Adapter::Test::Stubs.new do |stub|
@@ -604,7 +604,7 @@ def build_form_encoded_response(payload)
       @client.fetch_access_token!(
         :connection => connection
       )
-    end).to raise_error(Signet::AuthorizationError)
+    end).to raise_error(Signet::UnexpectedStatusError)
     stubs.verify_stubbed_calls
   end