-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add esm options for Nodejs #1886
Conversation
@bcoe, would you mind taking a look whenever you have a minute? Thank you! |
In the pull request description, could you describe why these files are changing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the majority of the node_esm_mono_repo_library
files are the same as the non-ESM versions?
Could we consider giving jinja multiple search paths:
loader = FileSystemLoader(["/override/templates", "/default/templates"])
And just add the template files that differ?
If this change could be done without too much refactoring, it would make it much easier to update templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, with the suggestion that we refactor to use two template directories, so that we don't need duplicate copies of CONTRIBUTING, LICENSE, .eslintignore, etc.
After looking into this, I'm a bit hesitant to do this because it would require refactoring this function (which renders the templates) to accept a List of template paths, vs. a string. That would affect Python and Java as well. I've created a bug for this: #1897 |
Most of the files are templates, the main changes are: