Skip to content
This repository has been archived by the owner on Dec 7, 2017. It is now read-only.

Switched appengine_config to use site.addsitedir() #9

Merged
merged 2 commits into from
Aug 14, 2014
Merged

Switched appengine_config to use site.addsitedir() #9

merged 2 commits into from
Aug 14, 2014

Conversation

webmaven
Copy link
Contributor

Replacing sys.path.insert() with site.addsitedir() makes it possible to import namespace package dependencies. Closes Issue #8.

webmaven added 2 commits July 27, 2014 16:25
Replacing sys.path.insert() with site.addsitedir() makes it possible to import namespace package dependencies. Closes Issue #8.
@webmaven
Copy link
Contributor Author

BTW, I signed the Google CLA a few days ago, but haven't received confirmation yet. How soon until this PR can be reviewed (presumably by @proppy or @henriquez)?

@webmaven
Copy link
Contributor Author

webmaven commented Aug 5, 2014

@proppy is off on vacation until the end of August. Can anyone else take a look at this? @henriquez? @dhermes? @dansanderson?

@henriquez
Copy link
Contributor

+sfife & dan s are you handling the getting started experience now?

On Tue, Aug 5, 2014 at 7:29 AM, Michael R. Bernstein <
[email protected]> wrote:

@proppy https://github.com/proppy is off on vacation until the end of
August. Can anyone else take a look at this? @henriquez
https://github.com/henriquez?


Reply to this email directly or view it on GitHub
#9 (comment)
.

@webmaven
Copy link
Contributor Author

webmaven commented Aug 6, 2014

@henriquez, just a clarification: The 'skeleton' versions of these repos aren't the ones used in the 'try appengine' part of the 'getting started' experience. Those are the 'try' repos and are apparently maintained separately. I decided to contribute PRs to the 'skeletons' first and see how it went. If successful I will also submit PRs for the 'try' apps.

lesv pushed a commit that referenced this pull request Aug 14, 2014
Switched appengine_config to use site.addsitedir()
@lesv lesv merged commit 9e15cd9 into googlearchive:master Aug 14, 2014
@webmaven
Copy link
Contributor Author

Thanks, @lesv!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants