gftools mode for crater #1069
Merged
gftools mode for crater #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes the ability to run both modes at once.
This happens sometimes in gftools, specifically if an error occurs in the ninja subprocess.
This will only run gftools mode for fonts using the default recipeProvider.
rsheeter
reviewed
Oct 28, 2024
| } | ||
|
|
||
| fn should_build_in_gftools_mode(src_path: &Path, config: &Config) -> bool { | ||
| // skip noto, which have an implicitly different recipe provider |
There was a problem hiding this comment.
can we link to where python does this implicit recipe provider selection?
There was a problem hiding this comment.
it doesn't, gftools cannot build these fonts, even with python.
There was a problem hiding this comment.
Maybe we should refer the reader to https://github.com/googlefonts/oxidize/blob/main/text/2024-06-26-fixes-and-nonstandard-builds.md#noto ?
rsheeter
reviewed
Oct 28, 2024
rsheeter
reviewed
Oct 28, 2024
fontc_crater/src/ci.rs
Outdated
| return false; | ||
| } | ||
|
|
||
| // if there is a recipe provider other than googlefonts, we skip |
There was a problem hiding this comment.
should tersely say why, e.g. because we have no idea what it will do, it's arbitrary code
rsheeter
reviewed
Oct 28, 2024
resources/scripts/ttx_diff.py
Outdated
| cmd.append(str(source)) | ||
|
|
||
| build(cmd, build_dir) | ||
|
|
||
|
|
||
| def run_gftools( | ||
| source: Path, config: Path, build_dir: Path, fontc_bin: Union[Path, None] = None |
There was a problem hiding this comment.
Union[Path, None] => Optional[Path]
rsheeter
reviewed
Oct 28, 2024
resources/scripts/ttx_diff.py
Outdated
| @@ -259,6 +285,9 @@ def copy(old, new): | |||
| return new | |||
|
|
|||
|
|
|||
| # def find_and_copy_one_file(from_dir: Path, to_file: Path): | |||
rsheeter
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires everything up to get gftools working in crater.
Parse more config items google-fonts-sources#24 andSupport for fontc and crater gftools#1047