Reverse TrueType glyph contour direction by default to match fontmake #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
force-pushed
the
reverse-contours
branch
from
9774435 to
eefed20
Compare
anthrotype
force-pushed
the
reverse-contours
branch
2 times, most recently
from
b97ec63 to
f059122
Compare
|
with this PR (without --keep-direction), running ttx_diff.py against Oswald.glyphs gives no diffs in glyf table for the default profile but a few diffs in the gvar. Not sure why: --- build/default/fontc.gvar.ttx 2023-10-04 17:32:35.827998928 +0100
+++ build/default/fontmake.gvar.ttx 2023-10-04 17:32:35.827998928 +0100
@@ -84,6 +84,7 @@
<delta pt="13" x="23" y="19"/>
<delta pt="14" x="-11" y="19"/>
<delta pt="15" x="-8" y="0"/>
+ <delta pt="16" x="-25" y="-18"/>
<delta pt="18" x="22" y="122"/>
<delta pt="20" x="-6" y="0"/>
</tuple>
@@ -91,16 +92,27 @@
<coord axis="wght" value="1.0"/>
<delta pt="0" x="38" y="0"/>
<delta pt="1" x="50" y="0"/>
+ <delta pt="2" x="84" y="0"/>
<delta pt="3" x="84" y="-40"/>
+ <delta pt="4" x="119" y="-40"/>
<delta pt="5" x="119" y="28"/>
+ <delta pt="6" x="92" y="28"/>
<delta pt="7" x="92" y="-17"/>
+ <delta pt="8" x="119" y="-17"/>
<delta pt="9" x="119" y="40"/>
+ <delta pt="10" x="84" y="40"/>
<delta pt="11" x="84" y="0"/>
+ <delta pt="12" x="74" y="0"/>
<delta pt="13" x="74" y="-32"/>
<delta pt="14" x="92" y="-32"/>
<delta pt="15" x="109" y="0"/>
+ <delta pt="16" x="98" y="0"/>
+ <delta pt="17" x="74" y="0"/>
<delta pt="18" x="74" y="-60"/>
+ <delta pt="19" x="0" y="0"/>
<delta pt="20" x="73" y="0"/>
+ <delta pt="21" x="0" y="0"/>
+ <delta pt="22" x="0" y="0"/>
</tuple>
</glyphVariations>
<glyphVariations glyph="AEacute">
@@ -20774,6 +20786,7 @@
<delta pt="6" x="-18" y="-14"/>
<delta pt="8" x="-15" y="32"/>
<delta pt="10" x="-18" y="0"/>
+ <delta pt="11" x="-31" y="-14"/>
<delta pt="13" x="31" y="52"/>
<delta pt="15" x="10" y="0"/>
</tuple>
@@ -20785,6 +20798,7 @@
<delta pt="6" x="53" y="-6"/>
<delta pt="8" x="37" y="-35"/>
<delta pt="10" x="53" y="0"/>
+ <delta pt="11" x="9" y="-6"/>
<delta pt="13" x="-1" y="-37"/>
<delta pt="15" x="41" y="0"/>
</tuple>
@@ -20798,6 +20812,7 @@
<delta pt="4" x="-48" y="0"/>
<delta pt="6" x="-84" y="0"/>
<delta pt="9" x="-84" y="21"/>
+ <delta pt="11" x="-81" y="0"/>
<delta pt="13" x="-48" y="45"/>
<delta pt="15" x="-106" y="0"/>
</tuple> |
using the new kurbo's BezPath::reverse_subpaths() Fixes #174
anthrotype
force-pushed
the
reverse-contours
branch
from
c7f6974 to
ee25d80
Compare
dfrg
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174
but somewhat blocked on googlefonts/fontations#640Now using the latest kurbo's BezPath::reverse_subpaths() instead of ReverseContourPen