Merge pull request #2019 from googlefonts/issue-2018-review-undo-labe…

…ls-font-info Review undo labels 'font info'
googlefonts · Feb 11, 2025 · e74a65e · e74a65e
2 parents 08175e0 + 96965c0
commit e74a65e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/fontra/views/fontinfo/panel-cross-axis-mapping.js b/src/fontra/views/fontinfo/panel-cross-axis-mapping.js
@@ -352,7 +352,7 @@ class CrossAxisMappingBox extends HTMLElement {
           } else {
             mapping[`${prop}Location`][event.key] = defaultValue;
           }
-        }, `edit ${prop} location ${event.key}`);
+        }, `edit ${prop} location ${event.key}`); // TODO: translation
       });
     }
 

diff --git a/src/fontra/views/fontinfo/panel-development-status-definitions.js b/src/fontra/views/fontinfo/panel-development-status-definitions.js
@@ -228,7 +228,7 @@ class StatusDefinitionBox extends HTMLElement {
   deleteStatusDef(statusIndex) {
     const undoLabel = translate(
       "development-status-definitions.undo.delete",
-      `'${this.statusDef.name}'`
+      `'${this.statusDef.label}'`
     );
     const root = { customData: this.fontController.customData };
     const changes = recordChanges(root, (root) => {

diff --git a/src/fontra/views/fontinfo/panel-font-info.js b/src/fontra/views/fontinfo/panel-font-info.js
@@ -45,7 +45,7 @@ export class FontInfoPanel extends BaseInfoPanel {
 
     this.infoForm.onFieldChange = async (fieldItem, value, valueStream) => {
       const [rootKey, itemKey] = JSON.parse(fieldItem.key);
-      const undoLabel = `change ${itemKey ? itemKey : rootKey}`;
+      const undoLabel = `change ${itemKey ? itemKey : rootKey}`; // TODO: translation
 
       const root = {
         fontInfo: await this.fontController.getFontInfo(),