Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework font sources UI #2007

Merged
merged 23 commits into from
Feb 11, 2025
Merged

Rework font sources UI #2007

merged 23 commits into from
Feb 11, 2025

Conversation

ollimeier
Copy link
Collaborator

Fixes #1997

  • I use "add-remove-buttons" (similar to other areas of Fontra) to add or remove a font source, this makes the repeating trash-icon redundant
  • When adding a new font source, this will be 'selected'.
  • With arrow up and down you can go to previous or next source (this will be ignored if the focus is for example on an input)

@ollimeier
Copy link
Collaborator Author

Short demo:

Screen.Recording.2025-02-04.at.15.46.28.mp4

Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It mostly works well. If I use the arrow keys, and the list of sources does not fit, the selection can get out of view. You should use scrollIntoView.

I have not done a thorough code review yet, but left one comment.

src/fontra/views/fontinfo/panel-sources.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@justvanrossum justvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual feedback: I would like the elements of the source panel to be more left aligned, instead of floating in the middle.

@ollimeier ollimeier force-pushed the issue-1997-rework-font-sources-UI branch from 093d2a5 to 5594222 Compare February 6, 2025 13:36
@ollimeier ollimeier merged commit 9ee577d into main Feb 11, 2025
5 checks passed
@ollimeier ollimeier deleted the issue-1997-rework-font-sources-UI branch February 11, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework font sources UI
2 participants