-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework font sources UI #2007
Rework font sources UI #2007
Conversation
Short demo: Screen.Recording.2025-02-04.at.15.46.28.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It mostly works well. If I use the arrow keys, and the list of sources does not fit, the selection can get out of view. You should use scrollIntoView.
I have not done a thorough code review yet, but left one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visual feedback: I would like the elements of the source panel to be more left aligned, instead of floating in the middle.
093d2a5
to
5594222
Compare
Fixes #1997