Guess glyph string for placeholder glyphs without code points #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledhosny
force-pushed
the
guess-placeholder-string
branch
from
95a1b50 to
7d8e70c
Compare
Guess placeholder string from glyph name for glyphs without code points. Checks for the extensions used for Arabic positional forms and add Zero Width Joiner as appropriate to force the desired positional form. The glyph-shape-placeholder div needs dir="auto" as ZWJ gets ignored at string boundaries if text direction is LTR (which is the default in HTML). With dir="auto", the direction will be resolved based on the string, so it will be RTL for Arabic text.
khaledhosny
force-pushed
the
guess-placeholder-string
branch
from
7d8e70c to
5b939de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in #2005
This works in the font overview, but I didn’t manage to find the relevant code in editor, so editing such glyphs still does not shows blank placeholder.