Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review undo labels 'font info' #2019

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Review undo labels 'font info' #2019

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/fontra/views/fontinfo/panel-cross-axis-mapping.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ class CrossAxisMappingBox extends HTMLElement {
} else {
mapping[`${prop}Location`][event.key] = defaultValue;
}
}, `edit ${prop} location ${event.key}`);
}, `edit ${prop} location ${event.key}`); // TODO: translation
});
}

Expand Down
2 changes: 1 addition & 1 deletion src/fontra/views/fontinfo/panel-development-status-definitions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ class StatusDefinitionBox extends HTMLElement {
deleteStatusDef(statusIndex) {
const undoLabel = translate(
"development-status-definitions.undo.delete",
`'${this.statusDef.name}'`
`'${this.statusDef.label}'`
);
const root = { customData: this.fontController.customData };
const changes = recordChanges(root, (root) => {
Expand Down
2 changes: 1 addition & 1 deletion src/fontra/views/fontinfo/panel-font-info.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class FontInfoPanel extends BaseInfoPanel {

this.infoForm.onFieldChange = async (fieldItem, value, valueStream) => {
const [rootKey, itemKey] = JSON.parse(fieldItem.key);
const undoLabel = `change ${itemKey ? itemKey : rootKey}`;
const undoLabel = `change ${itemKey ? itemKey : rootKey}`; // TODO: translation

const root = {
fontInfo: await this.fontController.getFontInfo(),
Expand Down