Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide UFO structure #705

Closed
wants to merge 1 commit into from
Closed

Provide UFO structure #705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/gftools/builder/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,9 @@ def run_fontmake(self, source, args):
args["check_compatibility"] = self.config["checkCompatibility"]
if "glyphData" in self.config:
args["glyph_data"] = self.config["glyphData"]
# The following line should be removed once we require
# fontmake >= 3.7.1
args["ufo_structure"] = "package"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ufo_structure parameter didn't exist before 3.7.0 so in practice passing this parameter is equivalent to requiring fontmake >= 3.7.0 (which you did not do in pyproject.toml's dependencies as far as I can tell).
It's probably better to do nothing and rely on the latest 3.7.1 to just fix the issue.
I can also "yank" 3.7.0 if you want (make it unavailable from pip install unless one explicitly requests fontmake==3.7.0), but maybe it's not worth it, it was online only a couple days

FontProject().run_from_glyphs(source, **args)
elif source.endswith(".designspace"):
args["check_compatibility"] = self.config["checkCompatibility"]
Expand Down