Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unnecessarily drop LTR kerns when combining with RTL #1041

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

anthrotype
Copy link
Member

Fixes #1039

--- master_ufo/PlaypenSans-Regular.ufo/kerning.plist	2024-10-31 10:32:42
+++ master_ufo_2/PlaypenSans-Regular.ufo/kerning.plist	2024-10-31 10:32:52
@@ -14,7 +14,11 @@
     </dict>
     <key>public.kern1.quotesingle</key>
     <dict>
+      <key>public.kern2.A</key>
+      <integer>-49</integer>
       <key>public.kern2.bet-hb</key>
+      <integer>-20</integer>
+      <key>public.kern2.space</key>
       <integer>-20</integer>
     </dict>
     <key>public.kern1.space</key>

@anthrotype
Copy link
Member Author

anthrotype commented Oct 31, 2024

maybe I'll try to distill a unit test from Simon's test file

EDIT: did that in #1042

Copy link
Collaborator

@simoncozens simoncozens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@anthrotype anthrotype merged commit 2c6181a into main Nov 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merging of kerningLTR and kerningRTL drops kerns
2 participants