Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler requirements #22

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Compiler requirements #22

wants to merge 16 commits into from

Conversation

chrissimpkins
Copy link
Member

Closes #19

@rsheeter
Copy link
Contributor

rsheeter commented Jun 2, 2022

QQ, do you have an ETA for a draft of this?

@madig
Copy link

madig commented Jun 7, 2022

@rsheeter @chrissimpkins #23

@rsheeter
Copy link
Contributor

rsheeter commented Jun 7, 2022

General feedback: overly focused on implementation details, not enough on the impact of the situation. It's hard to reason about ROI from what is provided at time of writing.


## What Do We Need?

An at least 10x faster compiler using less memory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes 30 minutes to compile Noto therefore 10x faster doesn't follow.

How often do people compile Noto? What happens if it takes half an hour? Why is there ROI for Google in making take half the time vs a tenth vs a hundredth, where does the return fall off?


As soon as possible.

## Implementation Requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance none of these appear to be requirements. Recommendations might be more appropriate.


## When Do We Need It?

As soon as possible.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not helpful. More useful would be some description of the impact of not having a faster compiler over different periods of time. If there is no speedup for a year, what harm would there be, how much does it cost us?

What if we could make compiling Noto take 10 minutes through a modest investment in improving fontmake and achieving 10+x faster was a large investment, which way should we go and why?

Comment on lines +91 to +92

[how do these diverge from those required for subsetting?]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subsetting is typically done on a font binary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add high performance, correct font compiler requirements document
3 participants