fix InfoCompiler overwriting the default master's codepage range bits #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…less we have a 'cmap' Fixes #897 The temp font in InfoCompiler doesn't have a 'cmap' table so, unless the info dict defines explicit openTypeOS2CodePageRanges, the existing ulCodePageRange1/2 won't be overwritten.
we now use the same copy in fonttools OS/2 table module
so not to break external code which might rely on the old function which we removed
|
i'm going to merge this as i'm confident it's the right fix, but Khaled feel free to review later if you want |
|
LGTM, thanks Cosimo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a designspace
<variable-font>contains apublic.fontInfolib key with overrides for the default master's fontinfo.plist to be applied on the VF binary font, and this does not define explicitopenTypeOS2CodePageRanges, the way the InfoCompiler works (as a sublcass of the BaseOutlineCompiler) means that the codepage range bits computed on its empty temporary TTFont (without any glyphs nor cmap) will overwrite the good codepage bits that were previously computed on the default master TTFont.This PR will make sure that this doesn't happen. Also we can use the
calcCodePageRangesfunction that is in fonttools now (added by @khaledhosny last year) instead of keeping our own duplicate in ufo2ft.util.