Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late initialise upstream socket to prevent session map lock #781

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

XAMPPRocky
Copy link
Collaborator

I thought I had already done this, but this moves the upstream socket initialisation to on use rather than in the Session::new initialisation. This removes the await point from session creation, preventing session map locking, as such I also removed the try_get, and then also removed SessionArgs as it was unneeded redirection.

@XAMPPRocky XAMPPRocky force-pushed the ep/late-init-upstream-socket branch from e26dab4 to 7b5f90b Compare September 4, 2023 10:03
@markmandel markmandel enabled auto-merge (squash) September 6, 2023 18:13
@markmandel markmandel merged commit f32387f into main Sep 6, 2023
5 checks passed
@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 6125c5f1-1aed-4087-b4e4-9099f2f4fa9c

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/781/head:pr_781 && git checkout pr_781
cargo build

@markmandel markmandel deleted the ep/late-init-upstream-socket branch September 20, 2023 15:53
@markmandel markmandel added the kind/bug Something isn't working label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants